Add model parameters to Estimator, and bump library version to 1.13.0 #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary version to 1.13.0
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
- Coverage 93.75% 93.67% -0.08%
==========================================
Files 55 55
Lines 4034 4079 +45
==========================================
+ Hits 3782 3821 +39
- Misses 252 258 +6
Continue to review full report at Codecov.
|
RodrigoAtAWS
changed the title
laurenyu
reviewed
Nov 1, 2018
There was a problem hiding this comment.
make sure @eslesar-aws has a chance at some point to look at the doc changes as well
src/sagemaker/estimator.py
Outdated
| @@ -601,6 +644,7 @@ def __init__(self, entry_point, source_dir=None, hyperparameters=None, enable_cl | |||
| Valid values are defined in the Python logging module. | |||
| code_location (str): Name of the S3 bucket where custom code is uploaded (default: None). | |||
| If not specified, default bucket created by ``sagemaker.session.Session`` is used. | |||
| **kwargs: Additional kwargs passed to the ``EstimatorBase`` constructor. | |||
There was a problem hiding this comment.
remove this line (it's already on l. 652)
There was a problem hiding this comment.
Will remove, thanks for pointing it out.
There was a problem hiding this comment.
Now I'm curious how I even got that line there. I'll do a second pass over the code changes.
laurenyu
reviewed
Nov 1, 2018
README.rst
Outdated
| Incremental Training | ||
| ~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Incremental training allows you to bring a pre-trained model into a SageMaker training job, to use as a starting point for a new model. |
There was a problem hiding this comment.
nitpick: remove the comma in this sentence
There was a problem hiding this comment.
Will also remove.
Removed unnecessary comma from sentence.
Removed duplicated line
laurenyu
approved these changes
Nov 1, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
…aws#450) * Add incremental training model parameters to Estimator, and bump library version to 1.13.0 * Update README.rst Removed unnecessary comma from sentence. * Update estimator.py Removed duplicated line
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
metrizable
pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Dec 1, 2020
…3.0 (aws#450) * add spark image_uri_retriever support for framework_version 3.0 * changing framework_version to 2.4 in spark unit tests * fix spark integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This code change adds the following changes to Estimators:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.